cds-snc / notification-planning-core

Project planning for GC Notify Core Team
0 stars 0 forks source link

Use a custom sender ID for international sending #378

Open jimleroyer opened 2 weeks ago

jimleroyer commented 2 weeks ago

Description

As a recipient of an international SMS sent via GCNotify, I want to have an identification of the sender, So that I know who sent the SMS.

As a British telecom provider, I want SMS senders to use IDs, So that I can identify these and get these to pass our internal filters.

As a product owner of GCNotify, I want our SMS to use a custom sender ID, When sent internationally, So that these are not blocked by destination countries that require these.

WHY are we building?

To improve the international sending of SMS.

WHAT are we building?

Define a custom sender ID for Pinpoint that we can use at the international level. Probably not to be used nationally as this is not used anyway.

VALUE created by our solution

More reliance for international sending of SMS.

Acceptance Criteria

Sending metrics at the international level is improved for key destinations that we know require the usage of sender ID.

QA Steps

Pinpoint:

SNS:

sastels commented 2 weeks ago
sastels commented 1 week ago

WIP https://github.com/cds-snc/notification-api/pull/2221

sastels commented 1 week ago

just have to sort out some tests...

sastels commented 1 week ago

oh! last thing I tried yesterday fixed the tests! ok, will get to review today...

sastels commented 1 week ago

approved and will merge and test tomorrow.

sastels commented 1 week ago

Note that in staging and production I've set the default sender id to CANADA-CA

P0NDER0SA commented 1 week ago

Steve is gonna merge and test today

sastels commented 1 week ago

merged into staging and tested! Ready for QA there or after we release to prod (hopefully Thursday)

ben851 commented 6 days ago

Released to Prod, ready for QA

jimleroyer commented 4 days ago

Completed QA and good to go. ✅