cds-snc / notification-planning-core

Project planning for GC Notify Core Team

0 stars 0 forks source link

Use template category to determine Pinpoint pool #382

Open sastels opened 3 months ago

sastels commented 3 months ago

Description

As a Notify user, I need to have my SMS sent by the appropriate vehicle (ie shortcode or longcode)

WHY are we building?

We want the Pinpoint pool selection to be dynamically based on the template category.

WHAT are we building?

Use the template category for Pinpoint pool selection.

VALUE created by our solution

The short code is used appropriately.

Acceptance Criteria

[x] Pinpoint pool is chosen based on the category sending vehicle.
[x] The App team signs off on the change.

QA Steps

[x] Bug bash on sending templates for different categories

sastels commented 3 months ago

started PR https://github.com/cds-snc/notification-api/pull/2216

sastels commented 3 months ago

Will finish PR today

sastels commented 3 months ago

ready for review https://github.com/cds-snc/notification-api/pull/2216

sastels commented 3 months ago

reviewed by Jimmy and Andrew. I added an Enum as suggested by Andrew and waiting for him to give it another look.

P0NDER0SA commented 3 months ago

will need another look.. Steve and Andrew will circle back

sastels commented 3 months ago

Andrew happy, will merge into staging and test tomorrow...

sastels commented 3 months ago

Why didn't I merge Thursday :thinking: Will merge Monday...

sastels commented 3 months ago

Oooops celery doesn't have the new feature flag. Let's fix that https://github.com/cds-snc/notification-manifests/pull/2773

sastels commented 3 months ago

in staging and all good now.

P0NDER0SA commented 3 months ago

Steve is gonna investigate some celery errors

sastels commented 3 months ago

22 duplicate key errors (notification ids) during the nightly performance test. I suspect that notifications were created but then something crashed and they got retried (and threw an error since they were already in the database there). Not related to Pinpoint / categories (and were emails in any case).

P0NDER0SA commented 3 months ago

Jimmy might QA this today

sastels commented 3 months ago

Jimmy should QA this today.

jimleroyer commented 3 months ago

Jimmy organized a bug bash on Thursday morning for al of us to test this feature in staging.

P0NDER0SA commented 2 months ago

Bug Bash was done and all is good! Moving to done