search

cds-snc / notification-planning-core

Project planning for GC Notify Core Team
0 stars 0 forks source link

Pinpoint SMS dashboard not showing all sms errors #421

Closed sastels closed 1 day ago

sastels commented 2 months ago

Describe the bug

We can see errors in PinpointDirectPublishToPhoneNumber (where all sms results get dumped) but not all show up in PinpointDirectPublishToPhoneNumber/Failure

Bug Severity

See examples in the documentation

SEV-3 Minor doesn't affect users directly but affects our ability to find and fix issues.

To Reproduce

Steps to reproduce the behavior:

  1. Go to this PinpointDirectPublishToPhoneNumber query)))
  2. See some errors if you set the time frame big enough
  3. Look at PinpointDirectPublishToPhoneNumber/Failure))) for the same time frame
  4. Not all errors show up here.

Expected behavior

All errors should be saved in PinpointDirectPublishToPhoneNumber/Failure.

Impact

Makes it hard to find and fix sms sending issues

sastels commented 2 months ago

There was a copy/paste error so that one of the Pinpoint error types was missing from the Failures log group filter :/

This PR fixes: https://github.com/cds-snc/notification-terraform/pull/1531

Since this is done by a script rather than terraform proper I've click-ops'd in the change to staging and production.

P0NDER0SA commented 2 months ago

should be merged today!

sastels commented 2 months ago

Ready for QA. verify the "To Reproduce" steps do not show differences now.

ben851 commented 2 months ago

@pond to QA

P0NDER0SA commented 2 months ago

479 vs 444 on my queries. Good to Go!

pond commented 2 months ago

@ben851 I think you meant @P0NDER0SA not @pond - had me confused for a while there, thought this was some new kind of spam LOL :-)