sastels commented 4 days ago

Description

As a software developer working on GCNotify stack, I want the Python stack to be upgraded at latest supported version, So that I can leverage the latest features of the language and better/safer code.

As a system ops working on GCNotify stack, I want the Python stack to be upgraded at latest supported version, So that I can leverage the latest performance improvement And process notifications faster.

WHY are we building?

To get latest performance improvements, features and security updates of the Python language/runtime.

WHAT are we building?

Upgrade the stack to the latest possible version of Python. A few considerations:

It is possible that we cannot upgrade to the latest of the latest (3.12 at the time of this writing for the stable version), as this might be blocked by a dependency library that did not release a version supporting the latest. For example, we might have to upgrade from version 3.10 to version 3.11, and wait a bit longer to migrate to version 3.12.
The lambdas might have additional considerations that might limit the possible maximum Python version we can use, such as supported runtime and also monitoring libraries that need to support that environment (such as New Relic). Consider doing this work in #354 .

VALUE created by our solution

Better performance, security and reliability.

Acceptance Criteria

[ ] utils running on Python 3.12.
[ ] utils tests passing
[ ] admin / api / document-download-api work with new utils

QA Steps

[ ] Run smoke tests on 3.12 apps
[ ] bug bash on staging

sastels commented 3 days ago

Upgraded to 3.12.7 https://github.com/cds-snc/notification-utils/pull/326
tests passing locally.
Using this branch with 3.12 admin / api / dd-api (in progress)

jimleroyer commented 2 days ago

Steve found new tests in admin that were failing, triggered by the Python 3.12 upgrade. He fixed some but there might be some remaining.

jimleroyer commented 1 day ago

Steve fixed a few tests involving a specific Redis command that flowed down to the API command.

sastels commented 1 day ago

:/ It really wasn't a redis command problem, instead the problem that my poetry.lock file was not installing the latest version of the 3.12 utils branch. All good now though.

cds-snc / notification-planning-core