cds-snc / notification-planning

Project planning for GC Notify Team
5 stars 0 forks source link

'About your service' dropdown #1223

Closed adriannelee closed 5 months ago

adriannelee commented 1 year ago

Description

As a CDS CRM manager, I need new clients to log in the right field when they can't find their department on the dropdown so that I can keep the data clean without a lot of manual work.

As a francophone client, I need the "No search results" to be in English.

As screen magnifier user, I need to be able to read what I've selected when using a dropdown. Video clip

As a screen reader user, I need to press 'Enter' on a dropdown selection without submitting the form so that I can review what else is on the page before I submit.

WHY are we building / VALUE?

WHAT are we building?

Documentation and Artifacts

image.png

Acceptance Criteria

Related Research Airtable records

QA Steps

amazingphilippe commented 1 year ago

A bit more investigation on the overlapping text. This screenshot shows that the autocomplete input and suggestion don't quite align. Also noting that the color contrast of that suggestion backdrop probably doesn't pass 7:1, or even 4.5:1. One idea could be to remove it. I'm not sure we need it?

Private Zenhub Image

amazingphilippe commented 1 year ago

There is also a focus trap introduced by this component:

Private Zenhub Video

amazingphilippe commented 1 year ago

Fable testers confirmed the same bugs we have found.

amazingphilippe commented 10 months ago

Possible native way of doing this: https://www.htmhell.dev/adventcalendar/2023/2/#datalist-a-native-autosuggest

amazingphilippe commented 8 months ago

Adding more details about the focus trap:

Browser: Firefox Method: Just keyboard navigation, no voiceover.

Steps to reproduce:

  1. Tab until the autocomplete box
  2. Escape
  3. Shift-tab to move focus upwards
  4. Shift once to focus the autocomplete box again
  5. The next shift will focus at the top of the page, and you will be trapped within the top and autocomplete box elements.
YedidaZalik commented 7 months ago

Adding to Ally stmt

jzbahrai commented 6 months ago
  1. When the text is too long it gets cut off (we can make the text box larger, but dont know if we should?) (but it displays it correctly up top)
  2. Text behind -Making the text box larger fixes it
YedidaZalik commented 6 months ago

Andrew will review