Closed yaelberger-commits closed 3 months ago
This is the API PR : https://github.com/cds-snc/notification-api/pull/2108 the API PR should be deployed to PRD before the admin PR
ADMIN: https://github.com/cds-snc/notification-admin/pull/1755/files
@whabanks @andrewleith will take a look this week, and move it forward
Reviewed both PRs and added tests to the Admin PR. Ready to merge on Monday.
API merged to prod, Admin going out today.
One PR approved, more reviews after this by Andrew
Description
As the GC Notify team, we need to be able to separate out data from our heartbeat SMS/Email messages used to update our System Status page from legitimate messages from our clients so that we can ensure our metrics on the Activity Dashboard are accurate and representative of real client messages and not skewed by our system status checks.
WHY are we building? Currently our metrics on the Activity Dashboard and service reporting are skewed for SMS/Email by our heartbeat checks WHAT are we building? A new service for heartbeat that doesn't get tracked in our Activity dashboard VALUE created by our solution More accurate metrics and reporting data
Documentation and Artifacts
Acceptance Criteria
Given the heartbeat checks are happening every 5 minutes, when the GC Notify team looks at the reporting metrics on the Activity dashboard, then those heartbeats are not tracked there
[ ] Cypress UI tests if needed.
[ ] Generate appropriate log messages so that executions of this feature can be tracked
[ ] Can misuse of this feature cause harm? If yes, create an alert
A11y
Bilingualism
Privacy considerations
Security controls in place
Measuring success and metrics
QA Steps