cds-snc / notification-planning

Project planning for GC Notify Team
4 stars 0 forks source link

Remove heartbeat SMS/Email from GC Notify service and Activity dashboard #1495

Closed yaelberger-commits closed 3 months ago

yaelberger-commits commented 5 months ago

Description

As the GC Notify team, we need to be able to separate out data from our heartbeat SMS/Email messages used to update our System Status page from legitimate messages from our clients so that we can ensure our metrics on the Activity Dashboard are accurate and representative of real client messages and not skewed by our system status checks.

WHY are we building? Currently our metrics on the Activity Dashboard and service reporting are skewed for SMS/Email by our heartbeat checks WHAT are we building? A new service for heartbeat that doesn't get tracked in our Activity dashboard VALUE created by our solution More accurate metrics and reporting data

Documentation and Artifacts

Screenshot 2024-02-02 at 4.01.00 PM.png

Acceptance Criteria

Given the heartbeat checks are happening every 5 minutes, when the GC Notify team looks at the reporting metrics on the Activity dashboard, then those heartbeats are not tracked there

QA Steps

jzbahrai commented 5 months ago

This is the API PR : https://github.com/cds-snc/notification-api/pull/2108 the API PR should be deployed to PRD before the admin PR

ADMIN: https://github.com/cds-snc/notification-admin/pull/1755/files

foudamo commented 4 months ago

@whabanks @andrewleith will take a look this week, and move it forward

whabanks commented 4 months ago

Reviewed both PRs and added tests to the Admin PR. Ready to merge on Monday.

whabanks commented 4 months ago

API merged to prod, Admin going out today.

amazingphilippe commented 4 months ago

One PR approved, more reviews after this by Andrew