cds-snc / notification-planning

Project planning for GC Notify Team
4 stars 0 forks source link

Move the SENSITIVE_SERVICE variable to be part of the DB #1635

Closed jzbahrai closed 3 days ago

jzbahrai commented 1 month ago

Description

We can't store the SENSITIVE_SERVICE in the .env file anymore:

notification-manifests git:(task/add-sens) make encrypt-production
cd env/production &&\
    zip .env.zip .env &&\
    aws kms encrypt --key-id e9461cc1-4524-4b50-b6e6-583013da2904 --plaintext fileb://.env.zip --output text --query CiphertextBlob --region ca-central-1 | base64 --decode > .env.zip.enc.aws
updating: .env (deflated 47%)

An error occurred (ValidationException) when calling the Encrypt operation: 1 validation error detected: Value at 'plaintext' failed to satisfy constraint: Member must have length less than or equal to 4096

need to move it to the DB

Documentation and Artifacts

Good docs, figma mockups, ADRs, screenshots etc.

Acceptance Criteria

Given some context, when (X) action occurs, then (Y) outcome is achieved

Related Research Airtable records

QA Steps

yaelberger-commits commented 2 weeks ago

Most of the code done, would like @andrewleith to review

yaelberger-commits commented 2 weeks ago

Issue related to bug with reply-to and CSV files

yaelberger-commits commented 2 weeks ago

Merged code in Staging and tested Will go out in Prod today

yaelberger-commits commented 2 weeks ago

Need another PR to get rid of configs in production

yaelberger-commits commented 2 weeks ago

In prod now, removed from manifest repo, should go out with today's deploy