search

cds-snc / notification-planning

Project planning for GC Notify Team
5 stars 0 forks source link

Missing French translation in Service settings #1686

Open jprince-cds opened 2 weeks ago

jprince-cds commented 2 weeks ago

Describe the bug

Sentence is missing a French translation on the screen to "Change your sending email address" in Service settings.

Bug Severity

Potential OL breach.

To Reproduce

Steps to reproduce the behavior:

  1. Switch your Notify language to French.
  2. Click on Paramètres of a service.
  3. Click on Modifier next to "Nom de l'adresse courriel d'envoi"
  4. See untranslated string: "You may use letters, numbers, dots, dashes or underscores."

Screenshots

image.png

Additional context

Reported in Freshdesk Ticket #19708

yaelberger-commits commented 1 week ago

@amazingphilippe and @YedidaZalik this is a bug we should prioritize because it's on a visible page

YedidaZalik commented 1 week ago

Prepped and emailed to MSB for translation: https://docs.google.com/document/d/1NHRziv9jNAtQFZDjGVQCfFS78d3W4ThGoBxVUPeDxww/edit?tab=t.0

amazingphilippe commented 1 week ago

We can probably reuse content from the create-a-service flow

amazingphilippe commented 1 week ago

Pull request to fix the issue: https://github.com/cds-snc/notification-admin/pull/1988