cds-snc / notification-terraform

Terraform for notification.canada.ca
MIT License
13 stars 6 forks source link

Removing bump and push on prod release #1431

Closed ben851 closed 1 month ago

ben851 commented 1 month ago

Summary | Résumé

Removing bump version and push tag on production releases. Because this is not required for prod. I accidentally added it in when I copy/pasted the new TF Apply workflow from staging.

Related Issues | Cartes liées

Part of OIDC tuning

Test instructions | Instructions pour tester la modification

TF Apply works

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

jimleroyer commented 1 month ago

Can you add the why on the description of the PR please?