cds-snc / notification-terraform

Terraform for notification.canada.ca
MIT License
13 stars 6 forks source link

Terraform newrelic alerts and Entity Data #1436

Closed P0NDER0SA closed 1 month ago

P0NDER0SA commented 1 month ago

Summary | Résumé

Adding all existing FUNCTIONAL alerts as terraform code. Had to identify the alerts that are still using existing entity ids. The Entity is added as a data block (as entities are not something you can create with TF code). Also renamed a few things to remove the "terraform" designations I had.

Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/380

Test instructions | Instructions pour tester la modification

Monitor the Terragrunt Plan in this PR and look for the proper adjustments. Once it's merged, look for the alerts in NewRelic

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.