Adding all existing FUNCTIONAL alerts as terraform code. Had to identify the alerts that are still using existing entity ids. The Entity is added as a data block (as entities are not something you can create with TF code). Also renamed a few things to remove the "terraform" designations I had.
Test instructions | Instructions pour tester la modification
Monitor the Terragrunt Plan in this PR and look for the proper adjustments. Once it's merged, look for the alerts in NewRelic
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur
[X] This PR does not break existing functionality.
[X] This PR does not violate GCNotify's privacy policies.
[X] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
[X] This PR does not significantly alter performance.
[X] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).
⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.
Summary | Résumé
Adding all existing FUNCTIONAL alerts as terraform code. Had to identify the alerts that are still using existing entity ids. The Entity is added as a data block (as entities are not something you can create with TF code). Also renamed a few things to remove the "terraform" designations I had.
Related Issues | Cartes liées
https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/380
Test instructions | Instructions pour tester la modification
Monitor the Terragrunt Plan in this PR and look for the proper adjustments. Once it's merged, look for the alerts in NewRelic
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur