search

cds-snc / notification-terraform

Terraform for notification.canada.ca
MIT License
13 stars 6 forks source link

release 2.13.9 #1444

Closed ben851 closed 3 months ago

ben851 commented 3 months ago

Summary | Résumé

1440 K8s worker update - Staging @ben851

1441 Adding missing DNS entries @ben851

1442 Setting base domain on missing DNS entries @ben851

1443 Aligning weighted DNS entries for API with prod @ben851

Related Issues | Cartes liées

Release

Test instructions | Instructions pour tester la modification

TF Apply works Verify prod DNS.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

github-actions[bot] commented 3 months ago

Production: newrelic

✅   Terraform Init: success ✅   Terraform Validate: success ✅   Terraform Format: success ✅   Terraform Plan: success

Plan: 0 to add, 1 to change, 0 to destroy
Show summary | CHANGE | NAME | |--------|-----------------------------------------------| | update | `newrelic_workflow.terraform_notify_workflow` |
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # newrelic_workflow.terraform_notify_workflow will be updated in-place ~ resource "newrelic_workflow" "terraform_notify_workflow" { id = "b6ee8bdc-d939-4091-8e82-6212776c580b" name = "Terraform Notify Workflow - production" # (7 unchanged attributes hidden) - destination { - channel_id = "718ee534-9e6b-4e30-9c97-fd7ff2b066db" -> null - name = "Terraform Notify Slack Channel - production" -> null - notification_triggers = [ - "ACKNOWLEDGED", - "ACTIVATED", - "CLOSED", ] -> null - type = "SLACK_LEGACY" -> null - update_original_message = true -> null } + destination { + channel_id = "718ee534-9e6b-4e30-9c97-fd7ff2b066db" + name = (known after apply) + notification_triggers = (known after apply) + type = (known after apply) + update_original_message = true } # (1 unchanged block hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
github-actions[bot] commented 3 months ago

Production: eks

✅   Terraform Init: success ✅   Terraform Validate: success ✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success 

Plan: 5 to add, 0 to change, 0 to destroy
Show summary | CHANGE | NAME | |--------|-----------------------------------------------------------------| | add | `aws_route53_record.api-document-notification-canada-ca-cname` | | | `aws_route53_record.doc-notification-canada-ca-cname` | | | `aws_route53_record.document-notification-canada-ca-cname` | | | `aws_route53_record.documentation-notification-canada-ca-cname` | | | `aws_route53_record.notification-www-root` |
Show plan ```terraform Resource actions are indicated with the following symbols: + create Terraform will perform the following actions: # aws_route53_record.api-document-notification-canada-ca-cname will be created + resource "aws_route53_record" "api-document-notification-canada-ca-cname" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "api.document.notification.canada.ca" + records = [ + "notification-production-alb-1685085140.ca-central-1.elb.amazonaws.com", ] + ttl = 300 + type = "CNAME" + zone_id = "/hostedzone/Z07701011ICTZVSX5P68J" } # aws_route53_record.doc-notification-canada-ca-cname will be created + resource "aws_route53_record" "doc-notification-canada-ca-cname" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "doc.notification.canada.ca" + records = [ + "notification-production-alb-1685085140.ca-central-1.elb.amazonaws.com", ] + ttl = 300 + type = "CNAME" + zone_id = "/hostedzone/Z07701011ICTZVSX5P68J" } # aws_route53_record.document-notification-canada-ca-cname will be created + resource "aws_route53_record" "document-notification-canada-ca-cname" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "document.notification.canada.ca" + records = [ + "notification-production-alb-1685085140.ca-central-1.elb.amazonaws.com", ] + ttl = 300 + type = "CNAME" + zone_id = "/hostedzone/Z07701011ICTZVSX5P68J" } # aws_route53_record.documentation-notification-canada-ca-cname will be created + resource "aws_route53_record" "documentation-notification-canada-ca-cname" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "documentation.notification.canada.ca" + records = [ + "notification-production-alb-1685085140.ca-central-1.elb.amazonaws.com", ] + ttl = 300 + type = "CNAME" + zone_id = "/hostedzone/Z07701011ICTZVSX5P68J" } # aws_route53_record.notification-www-root will be created + resource "aws_route53_record" "notification-www-root" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "www.notification.canada.ca" + records = [ + "notification-production-alb-1685085140.ca-central-1.elb.amazonaws.com", ] + ttl = 300 + type = "CNAME" + zone_id = "/hostedzone/Z07701011ICTZVSX5P68J" } Plan: 5 to add, 0 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Cloudwatch log metric pattern is invalid: ["aws_cloudwatch_log_metric_filter.celery-error[0]"] WARN - plan.json - main - Cloudwatch log metric pattern is invalid: ["aws_cloudwatch_log_metric_filter.scanfiles-timeout[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.client_vpn"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.notification-canada-ca"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.notification-canada-ca-alt[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_alb.notification-canada-ca"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_listener.internal_alb_tls"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_listener.notification-canada-ca"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.internal_nginx_http"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-admin"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-api"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-document"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-document-api"] WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-documentation"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notification-canada-ca-eks-application-logs[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notification-canada-ca-eks-cluster-logs[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notification-canada-ca-eks-prometheus-logs[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.admin-evicted-pods[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.admin-pods-high-cpu-warning[0]"] WARN - plan.json - main -... ```
github-actions[bot] commented 3 months ago

Production: lambda-api

✅   Terraform Init: success ✅   Terraform Validate: success ✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success 

Plan: 0 to add, 1 to change, 0 to destroy
Show summary | CHANGE | NAME | |--------|------------------------------------------------------| | update | `aws_route53_record.api-weighted-100-notification-A` |
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_route53_record.api-weighted-100-notification-A will be updated in-place ~ resource "aws_route53_record" "api-weighted-100-notification-A" { id = "Z07701011ICTZVSX5P68J_api.notification.canada.ca_A_lambda" name = "api.notification.canada.ca" # (7 unchanged attributes hidden) ~ alias { ~ name = "d-0jho4qbdqi.execute-api.ca-central-1.amazonaws.com" -> "d-jwtzdgd9qg.execute-api.ca-central-1.amazonaws.com" # (2 unchanged attributes hidden) } # (1 unchanged block hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_api_gateway_domain_name.alt_api_lambda"] WARN - plan.json - main - Missing Common Tags: ["aws_api_gateway_domain_name.api"] WARN - plan.json - main - Missing Common Tags: ["aws_api_gateway_domain_name.api_lambda"] WARN - plan.json - main - Missing Common Tags: ["aws_api_gateway_rest_api.api"] WARN - plan.json - main - Missing Common Tags: ["aws_api_gateway_stage.api"] WARN - plan.json - main - Missing Common Tags: ["aws_appautoscaling_target.api"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.api_gateway_log_group"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.api_lambda_log_group[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.failed-login-count-5-minute-warning[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.logs-1-error-1-minute-warning-lambda-api[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.logs-1-error-1-minute-warning-salesforce-api[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.logs-10-error-5-minutes-critical-lambda-api[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.api"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.ecr"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.api"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.api_cloudwatch[0]"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_user.ecr-user"] WARN - plan.json - main - Missing Common Tags: ["aws_kinesis_firehose_delivery_stream.firehose-api-lambda-waf-logs"] WARN - plan.json - main - Missing Common Tags: ["aws_lambda_function.api"] WARN - plan.json - main - Missing Common Tags: ["aws_secretsmanager_secret.new-relic-license-key"] WARN - plan.json - main - Missing Common Tags: ["aws_wafv2_web_acl.api_lambda"] WARN - plan.json - main - Missing Common Tags:... ```
github-actions[bot] commented 3 months ago

Production: quicksight

✅   Terraform Init: success ✅   Terraform Validate: success ✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success 

Plan: 0 to add, 1 to change, 0 to destroy
Show summary | CHANGE | NAME | |--------|-------------------------------| | update | `aws_s3_object.manifest_file` |
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_s3_object.manifest_file will be updated in-place ~ resource "aws_s3_object" "manifest_file" { ~ etag = "3696c2177cd9e1be28ff597c24b10ae0" -> "221f592f333f2fc284626cfdb8c4bc80" id = "quicksight/s3-manifest-sms-usage.json" tags = {} + version_id = (known after apply) # (12 unchanged attributes hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_cloudformation_stack.sms-usage-notifications"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight-rds"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight-s3-usage"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight_vpc_connection_ec2"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight_vpc_connection_iam"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.quicksight"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.vpc_connection_role"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.jobs"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.login_events"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.notifications"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.organisation"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.services"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.sms_usage"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.templates"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.users"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_source.rds"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_source.s3_sms_usage"] WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_vpc_connection.rds"] WARN - plan.json - main - Missing Common Tags: ["aws_s3_object.manifest_file"] 38 tests, 19 passed, 19 warnings, 0 failures, 0 exceptions ```