cds-snc / notification-terraform

Terraform for notification.canada.ca
MIT License
13 stars 6 forks source link

Using AWS read only IAM for account link #1470

Closed ben851 closed 2 months ago

ben851 commented 2 months ago

Summary | Résumé

Forcing new relic AWS Account link to use the global AWS read only Policy.

Related Issues | Cartes liées

Troubleshooting newrelic staging

Test instructions | Instructions pour tester la modification

TF Apply works See if api-lambda for staging appears as an entity in NR

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

github-actions[bot] commented 2 months ago

Staging: newrelic

✅   Terraform Init: success ✅   Terraform Validate: success ✅   Terraform Format: success ✅   Terraform Plan: success ⚠️   Warning: resources will be destroyed by this change!

Plan: 1 to add, 0 to change, 1 to destroy
Show summary | CHANGE | NAME | |----------|----------------------------------------------------------------| | recreate | `aws_iam_role_policy_attachment.newrelic_aws_policy_attach[0]` |
Show plan ```terraform Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # aws_iam_role_policy_attachment.newrelic_aws_policy_attach[0] must be replaced -/+ resource "aws_iam_role_policy_attachment" "newrelic_aws_policy_attach" { ~ id = "NewRelicInfrastructure-Integrations-staging-20240724125752875200000001" -> (known after apply) ~ policy_arn = "arn:aws:iam::239043911459:policy/NewRelicCloudStreamReadPermissions-staging" -> "arn:aws:iam::aws:policy/ReadOnlyAccess" # forces replacement # (1 unchanged attribute hidden) } Plan: 1 to add, 0 to change, 1 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```