search

cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
34 stars 13 forks source link

Creating a form by opening a form file does not save it to account when signed in #3628

Open anikbrazeau opened 5 months ago

anikbrazeau commented 5 months ago

Description

When importing a JSON form file to create a form, it opens in the Preview/Test section. If you go to Forms, that form does not save to your forms. It seems you need to take the extra step to go to Edit and actually name the file and click save? This could lead to confusion and losing forms when importing more than one in succession.

Steps to reproduce

  1. Go to GC Forms
  2. Open a form file
  3. Go to Forms
  4. Go to Create new form
  5. Open another form file
  6. Go to Forms
  7. Notice it's empty

Details

Expected behaviour

Auto-named and auto-saved when imported?

Screenshots or videos

Opens to preview but does not save

timarney commented 5 months ago

Been wondering for a while if we should be taking folks to edit vs preview first ... thoughts?

anikbrazeau commented 5 months ago

Yeah I think that might be more expected? Or I wonder if conserving the name of the file and saving it when uploaded might also help if they land on preview?

Abi-Nada commented 5 months ago

Hi folks! This behaviour currently persists in Production - I'm going to de-scope it from the App Router work, and we can prioritize outside of this work

Abi-Nada commented 1 month ago

Current functionality is resulting in a few errors/support tickets when a user uploads a JSON file and immediately updates Settings before saving a draft. (These issues are labelled as "blocking" within this card).