cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
34 stars 13 forks source link

Title and H1 not announcing on confirmation loader or page #3665

Closed srtalbot closed 5 months ago

srtalbot commented 5 months ago

Previously we were setting the H1 on the confirmation page so that clients building forms could not update it and there would always be a consistent announcement for screen reader users.

Neither the Title nor H1 are set, focused, or announced for confirmation pages. Here is a test form on production.

image.png

Acceptance criteria:

timarney commented 5 months ago

Tracked back to this commit https://github.com/cds-snc/platform-forms-client/commit/99886ce11

See: https://github.com/cds-snc/platform-forms-client/commit/99886ce11#diff-b37a1d64831df182c5c1c25df7c76c9741ea896eeef904c4242f488f508e47eaR10

srtalbot commented 5 months ago

Options

  1. Create a H1 field in the form builder
  2. Set H2s on existing forms to an H1
  3. Provide an automatic Title

Option 3:

samsadasivan commented 5 months ago

PROPOSAL: Default confirmation message.

For the confirmation message, we can make it visually explicit or as a descriptor in the card itself. The Review page is the only element that is similar.

Review page:

Confirmation page:

We can either design it to be explicit or implicit.

Explicit:

Implicit

samsadasivan commented 5 months ago

Explicit:

image.png image.png
samsadasivan commented 5 months ago

Implicit:

image.png
samsadasivan commented 5 months ago
image.png
samsadasivan commented 5 months ago

Update :)

image.png
samsadasivan commented 5 months ago
image.png
samsadasivan commented 5 months ago

EN: Your form has been submitted --- Section title FR: Votre formulaire a été soumis --- Titre de la section

samsadasivan commented 5 months ago

SORRY - Work can be found under the CL file

Conditional Logic MVP/ 🟡 Right panel (dev test)/ Section: Monday May 21 notes -> "Title and H1 not announcing on confirmation loader or page"

timarney commented 5 months ago

Note:

We had a cypress test in place to detect that the H1 was present.

Screenshot 2024-05-24 at 9 38 51 AM

✅ The test was passing

But ...

The fixture data wasn't accurate. Forms published using the builder don't allow confirmation to be empty.


The fixture data used by the test has empty strings.

Screenshot 2024-05-24 at 9 37 53 AM
timarney commented 5 months ago

Merged to staging.

Abi-Nada commented 5 months ago

@Abi-Nada and @samsadasivan to test and confirm

Abi-Nada commented 5 months ago

Tested and can be closed!