Closed ShadeWyrm closed 1 month ago
@ShadeWyrm can you please add some test instructions to the PR description so folks without context can review without too much digging on what the PR does ?
@ShadeWyrm this is looking good
Thinking we can remove the getter / setter for the useTemplateStore
i.e. https://github.com/cds-snc/platform-forms-client/commit/3af5a8e96726b3eaa0c18989a57300be6aeedcdb does that work?
Get
formPurpose: s.formPurpose,
Update
updateField("formPurpose", purposeOption);
@ShadeWyrm this is looking good
Thinking we can remove the getter / setter for the
useTemplateStore
i.e. 3af5a8e does that work?Get
formPurpose: s.formPurpose,
Update
updateField("formPurpose", purposeOption);
Yah that should work just fine, it was a hold over from my testing, and figuring out the template store. I had assumed it was necessary, but the Linter brought that into question on my end. :) So just the property should be enough.
https://github.com/cds-snc/platform-forms-client/pull/3714#issuecomment-2142090035
Do you want to cherry pick that commit in or make the updates on you end?
This PR is a large chunk of the requirements from #3313
It is split off from #3647 to avoid issues with Salesforce Integration.
For Testing...
The UI/UX changes are on the Form Settings Page, and Publish page.
Publish Page:
Settings Page:
The pages should work the same and have valid relevant text in both languages.