cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
31 stars 13 forks source link

Order not as expected when adding questions to start section in relation to privacy statement #3717

Closed anikbrazeau closed 1 month ago

anikbrazeau commented 1 month ago

Description

When starting to build a form and adding questions they show up before the Privacy statement in the central interface but below it in the section/tree view on the right panel.

Steps to reproduce

  1. Go to design a form
  2. Add title and description
  3. Click on add form element
  4. Add radio buttons
  5. Add text to question
  6. See where it shows up on left side and on right panel

Details

Expected behaviour

Match the order in the edit interface centrally and in the table of contents in right panel

Screenshots or videos

Screenshot 2024-05-30 at 1.38.21 PM.png
timarney commented 1 month ago

@anikbrazeau @samsadasivan

Just to confirm --- we're looking to move the privacy statement block up in the editor correct?

If we do that ... which I do think makes sense the Add a form element button get a little more buried especially for screen readers needed to read all the policy text. Any thoughts on if we should address that or is that a later task?

anikbrazeau commented 1 month ago

That's a good consideration... I wonder if the Privacy Statement might eventually become a default section, which could solve this?

Just flagging, because the difference between the order on the left and on the right seemed jarring, but maybe it's just temporary?

timarney commented 1 month ago

I'll move it up as a starter.

timarney commented 1 month ago

Quick test ---

The question is pretty much off the screen --- and will be off-screen for tablet ...

@samsadasivan should we look to move policy to a section or do you have other ideas?

Screenshot 2024-06-03 at 9 45 54 AM
anikbrazeau commented 1 month ago

https://gcdigital.slack.com/archives/C0676D34GPR/p1717426472458999

image

image

anikbrazeau commented 1 month ago

Short-term solution:

  1. Collapse in-line guidance for privacy statement
  2. One sentence that is expandable, links in expanded
  3. Move up privacy statement
  4. Part of group release
  5. Do communications well in advance about impact to form order and layout

Justification for users: As we move toward adding sections and conditional logic, repositioning privacy statement, may alter forms, spacing issue, as we yield out more complex forms putting it upfront to help people decide whether they want to provide information, ask people to reach out if there's an issue

anikbrazeau commented 1 month ago

LATEST UPDATE: https://www.figma.com/design/2bmknDRpZXN3lwqhs7mqNH/Conditional-logic-MVP-(Groups%2C-Dynamic-fields%2C-Branching)?node-id=2797-5493&t=zpTXKzc6CthqTdnV-4