cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
31 stars 12 forks source link

* Update and add learn more administrative purposes box. #3757

Closed ShadeWyrm closed 3 weeks ago

ShadeWyrm commented 4 weeks ago

Closes #3753 &
Closes #3754

Closes #3750

github-actions[bot] commented 4 weeks ago

:test_tube: Review environment

https://bkigrfcspqy3pqxmdqlhrrswha0wavev.lambda-url.ca-central-1.on.aws/

anikbrazeau commented 4 weeks ago

Suggested change to pills: Rename pill under "Settings" to "Responses"

Rationale

To correspond with expanded scope beyond response delivery

Delivery option is the next structural level

Previously:

EN: Response delivery FR: Livraison des réponses

Screenshot 2024-06-06 at 2 39 06 PM Screenshot 2024-06-06 at 2 39 26 PM

Suggested adjustment:

EN: Responses FR: Réponses Screenshot 2024-06-06 at 2 39 02 PM Screenshot 2024-06-06 at 2 39 15 PM

anikbrazeau commented 4 weeks ago

Suggested tweaks to Settings page: Save button for each setting or for all settings and remove redundant line

1. Save button for each setting or for all settings or auto-save

Currently, Delivery option and Purpose and use have "Save changes" buttons but Data classification does not

2. Redundant content

Remove first instance of "GC Forms holds data temporarily. " in EN Remove first instance of "Formulaires GC conserve les données temporairement. " in FR

Screenshot 2024-06-06 at 2 45 28 PM

anikbrazeau commented 4 weeks ago

Suggested tweaks to administrative purpose modal

1. Italicize "Privacy Act"

2. Open links in new tab

Screenshot 2024-06-06 at 2 54 25 PM

anikbrazeau commented 4 weeks ago

Suggested tweaks to publish page

1. Match setting name with heading from settings in French

"Usage prévu" not "Objectif et utilisation"

Screenshot 2024-06-06 at 3 13 46 PM

2. Add a space before colon in French

Screenshot 2024-06-06 at 3 13 27 PM

3. Capitalize the first letter of each setting in French

"Pas définis" "Fins administratives" "Fin non-administratives"

Screenshot 2024-06-06 at 3 15 03 PM

Screenshot 2024-06-06 at 3 14 35 PM

Screenshot 2024-06-06 at 3 14 18 PM

anikbrazeau commented 4 weeks ago

It's currently possible to publish without completing settings requirements

The publish button was previously not there until all requirements were complete

Screenshot 2024-06-06 at 3 19 16 PM

Screenshot 2024-06-06 at 3 19 23 PM

anikbrazeau commented 4 weeks ago

Suggested change: Remove banner from "Form management" pill since these settings (Open/Close) can be modified post-publishing

Screenshot 2024-06-06 at 3 21 00 PM

Screenshot 2024-06-06 at 3 21 09 PM

anikbrazeau commented 4 weeks ago

Not sure if it's related so logged it separately, but as I was testing also encountered: https://github.com/cds-snc/platform-forms-client/issues/3761

anikbrazeau commented 4 weeks ago

Suggested change: Remove "(default)" / "(par défault) from dropdowns for classification (in settings and in edit)

Previously, when it was not a requirement for settings, "Protected A (default)" was the option that showed, if you change to "Unclassified" or "Protected B" it still says PA is default which is a bit strange in terms of experience.

Screenshot 2024-06-06 at 2 55 56 PM