search

cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
34 stars 13 forks source link

Form Template Upload does not immidiatley save template #3955

Closed bryan-robitaille closed 1 week ago

bryan-robitaille commented 3 months ago

Description

If a user attempts to modify the Delivery Settings for a form that has been uploaded, but not yet saved, a user is shown an error 552.

Steps to reproduce

  1. Upload a form JSON through the form-builder
  2. (user is immediately brought to the preview of the form)
  3. Click on "Settings" in left navigation
  4. Click on "Receive responses by email" under delivery options
  5. Click on "Save changes"
  6. A toast message with error 552 should appear

Expected behaviour

The user can modify the form settings immediately after uploading the form.

Screenshots or videos

There is a video, it just takes time to load

form upload errror

Additional context

Any other information about the problem here.

timarney commented 3 months ago

We've seen roughly this type of thing happen a few different ways.

@Abi-Nada @srtalbot --- thoughts on starting folks on the edit screen vs preview after the initial upload?

That's not a total solve but for sure would be an improvement ...wanted to suggest it before we work on this fix.

srtalbot commented 3 months ago

I think the main paths to opening a form file are:

  1. A form builder downloads a back-up version on their machine that they want to use later.
  2. A form builder shares the form with someone else to review / provide input.

Am I missing some others?

For both paths I think it's more useful to land on preview to see what the form looks like.

timarney commented 3 months ago

Can keep as preview -

Side note:

Button does say edit a form

Screenshot 2024-07-05 at 3 56 22 PM
Abi-Nada commented 1 week ago

Closing this issue as a duplicate - tackling 3628 will solve this