cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
34 stars 13 forks source link

feat: Conditional Input History - Forms-form #4036

Closed thiessenp-cds closed 2 months ago

thiessenp-cds commented 2 months ago

Conditional Input History - Forms-form

Adds conditional input history to the forms-forms. This adda the logic from group history and show-hide to only include the data that follows a user's branching path.

High Risk PR as this touches forms-forms (how a user submits data)

Testing

The main things to test are that nothing obvious is broken around form submissions. Also test that the correct data is submitted. See the below video for an example.

Also test that old forms work as they previously did. So a review page should not be displayed when submitting and submissions continue working as previously.

https://github.com/user-attachments/assets/9a994947-7d0f-4f20-8781-0e836c93bc0d

github-actions[bot] commented 2 months ago

:test_tube: Review environment

https://4ouzqz4a6gfkj4pxecb6jjky5i0zfqfc.lambda-url.ca-central-1.on.aws/

anikbrazeau commented 2 months ago

Tested this and it remembered my inputs in the draft preview/test, but did not submit the old data when I switched trigger answer to go down a different path.

I did notice one issue: in the response files (HTML, CSV and JSON), it does appear that answers are not in the same order as they are filled out by the user once submitted? @thiessenp-cds

Screenshot 2024-07-30 at 8 16 46 AM

As for old forms, a review page displayed for me, within this preview environment? Is the plan to change that with #4075?