cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
34 stars 13 forks source link

English option for "Review" and "Start" in dropdown of Branching/Logic set-up #4064

Closed anikbrazeau closed 2 months ago

anikbrazeau commented 2 months ago

Description

When using the product in French and navigating to the French branching page, there is a mix of English and French, in the dropdown to control the destination from the node.

Steps to reproduce

  1. Go to GC Forms staging
  2. Go to the French interface
  3. Create a form
  4. Go to branching
  5. Add a branch
  6. See "Review" in English even when editing in French on the French interface

Details

Expected behaviour

Matching language

Screenshots or videos

Screenshot 2024-07-24 at 3.17.03 PM.png
timarney commented 2 months ago

PR - https://github.com/cds-snc/platform-forms-client/pull/4088

anikbrazeau commented 2 months ago

Fixed! Thanks Tim!

anikbrazeau commented 2 months ago

This seems to be happening again.

In testing the staging environemtn on Tablet/Edge/French noticed both "Start" and "Review" show up.

Review option Start