Consistency in primary and secondary button placement

[anikbrazeau]

Description

In some modals and pages in the app, primary buttons are on the left of secondary buttons, in other places they are on the right.

To ensure consistency and predictability for users, we may want to revisit what that pattern looks like.

Steps to reproduce

1. Go to GC Forms > Edit
2. Add a question
3. Go to "More"
4. Then go to the top of the form and click the three dots to enter the modal for branding/classification
5. Notice how both treat buttons differently
6. There are likely some other instances where we also have a difference

Details

• Browser: Edge
• Operating system: Windows
• Environment: Staging
• Language: French
• Viewport: Tablet

Expected behaviour

Reevaluate all buttons.

Display button relationship the same way throughout the app. cc @samsadasivan @connorscarolyns should primary button be on left or right in relation to secondary?

Screenshots or videos

[anikbrazeau]

Consider putting the primary action first as it will be read first on screenreader

ex: Read "Continue" before "Back"