GCDS: Checkboxes - Githubissues

cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms

https://forms-staging.cdssandbox.xyz/

MIT License

34 stars 13 forks source link

GCDS: Checkboxes #4308

Closed samsadasivan closed 1 month ago

samsadasivan commented 1 month ago

Focus state has no outline
Not sure if Forms checkbox label supports hint messaging
Checkbox dimensions are off -Forms: 40px x 40px -GCDS: 48px x 48px
Typography doesn't match

DESKTOP

Forms label: Font Size = 20px, Line height = 28px (140%)
Forms hint: none?
GCDS label: Font Size = 20px, Line height = 24px (120%)
GCDS hint: Font Size = 20px, Line height = 24px (120%)

MOBILE

Forms label: Font Size = 20px, Line height = 28px (140%)
Forms hint: none?
GCDS label: Font Size = 16px, Line height = 24px (150%)
GCDS hint: Font Size = 16px, Line height = 24px (150%)
Checkbox label does not scale down on mobile

Current state

Desired state

timarney commented 1 month ago

Started a PR here

https://github.com/cds-snc/platform-forms-client/pull/4343

timarney commented 1 month ago

PR is merged.