Repeating set: Adding/removing does not work and inconsistent across elements

[anikbrazeau]

Description

The "Add to set" button and "Remove from set" button do not work They show up differently visually for address and individual names which include page text

Steps to reproduce

1. Add repeating set
2. Add individual names component
3. Add address component
4. Click on each and try to add / remove
5. See weirdness

Details

• Browser: Chrome
• Operating system: Mac
• Environment: PR
• Language: English
• Viewport: Desktop

Expected behaviour

Does "Remove from set" delete or simply remove from nesting? Do we need two "Add to set" links/buttons, the embedded and non-embedded?

Screenshots or videos

Private Zenhub Video

[timarney]

Tried address seems to work

https://github.com/user-attachments/assets/ae5919e8-1df2-48be-884f-e4388f03b85a

[anikbrazeau]

Ah, I was trying to select the card by clicking the general areas, not click inside the text input.

I did find something similar with move up move down -- where it loses focus and also stops working?

Also notice how email initially has the original side action menu and then switches to the bottom bar of actions/options?

Private Zenhub Video

[anikbrazeau]

Another example of the inconsistency: inside vs. outside of a set?

[timarney]

Working on some fixes here

https://github.com/cds-snc/platform-forms-client/pull/4346

[timarney]

Merged updates in #4346

[timarney]

@anikbrazeau

You should be able to re-test the latest on staging.

[anikbrazeau]

This works, assuming you click inside the text input for the form element label.