cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
34 stars 13 forks source link

AddressComplete - Nested Address "Click Through" #4451

Open ShadeWyrm opened 3 weeks ago

ShadeWyrm commented 3 weeks ago

Todo:

  1. Identify the behavior excpected from what should occur when a user clicks off a partial address complete on nested addresses.
  2. Implement

         Any thoughts on how we can handle if the user clicks out - just looking for thoughts ... this PR is a big improvement so will look to get it merged --- juts the 2 minor comments.
Screenshot 2024-10-22 at 2 21 40 PM

Originally posted by @timarney in https://github.com/cds-snc/platform-forms-client/issues/4444#issuecomment-2429960786

ShadeWyrm commented 3 weeks ago

The embedded component on their site removes the "- X Addresses", and leaves the cursor in the start of the combobox with a " "

So "King St W, Toronto, ON - 15489 Addresses" becomes " King St W, Toronto, ON"

anikbrazeau commented 3 weeks ago

Thoughts

Testing the address component with nested search

Preventing a non-specific group of addresses

Tradeoff: too much enforcement might prevent someone from submitting a non-conventional western address, we should be cognizant of losing the flexibility / modifiability of this component. A slight nudge or prompt that doesn't prevent them from continuing might make sense here?