cds-snc / platform-forms-client

NextJS application that serves the public-facing website for Forms
https://forms-staging.cdssandbox.xyz/
MIT License
35 stars 13 forks source link

chore: review clean up #4684

Open thiessenp-cds opened 22 hours ago

thiessenp-cds commented 22 hours ago

Summary | Résumé

1-3 sentence description of the changed you're proposing. Please include the GitHub issue number or relevant acceptance criteria.

To specify that this PR closes a particular issue you can use the following format to reference and issue closes #[issue number]. You can use any number of keywords to link an issue to a PR. Please see the following section of GitHub's documentation.

For any UI changes please include screenshots at different breakpoints. It would also be helpful to include a before and after comparison for each change i.e.

Before After
Insert Image showing before the change was made Insert Image showing after a change was made

Test instructions | Instructions pour tester la modification

Sequential steps (1., 2., 3., ...) that describe how to test this change. You should include anything outside the README that will help the developer access your changes and be able to test them such as any environmental setup steps and/or any time-based elements that this requires. This will help a developer test things out without too much detective work.

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

Are there any related issues or tangent features you consider out of scope for this issue that could be addressed in the future? If so please create issues and provide links in this section

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

github-actions[bot] commented 22 hours ago

:test_tube: Review environment

https://yilmlkt3q6yhnquwntpu3uvlge0ewmkc.lambda-url.ca-central-1.on.aws/