remove f-strings so we can be 3.5+ instead of 3.6+

cds-snc / pulse

Archived: [Project has been split out into two components, @ https://github.com/cds-snc/tracker and https://github.com/cds-snc/track-web ] Check whether a Government of Canada domain is adhering to best security practices.

Other

6 stars 1 forks source link

remove f-strings so we can be 3.5+ instead of 3.6+ #132

Closed buckley-w-david closed 6 years ago

buckley-w-david commented 6 years ago

John brought to my attention that f-strings are new in 3.6, so our claim of "3.5+" is actually wrong with our use of them.

As such (and since they are not that important) I've refactored the few places we use them into using the string format method instead.

evadb commented 6 years ago

@obrien-j I didn't realize they added the 'h' to python in 3.6 too ;)

obrien-j commented 6 years ago

Spelling is optional when parenting on 3 hours sleep!

On Tue, Jun 12, 2018, 4:43 PM David Buckley notifications@github.com wrote:

Merged #132 https://github.com/cds-snc/pulse/pull/132.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cds-snc/pulse/pull/132#event-1677272932, or mute the thread https://github.com/notifications/unsubscribe-auth/AQzO1O9pYMlzZvOCltQHmUSEWqCm7zFFks5t8CfTgaJpZM4UlC6r .