search

cds-snc / pulse

Archived: [Project has been split out into two components, @ https://github.com/cds-snc/tracker and https://github.com/cds-snc/track-web ] Check whether a Government of Canada domain is adhering to best security practices.
Other
6 stars 1 forks source link

Footer is not sticking to bottom of page on IE #79

Closed courtneycl closed 6 years ago

courtneycl commented 6 years ago

On IE

On load: image

Scroll a bit: image

evadb commented 6 years ago

grumble grumble ie grumble grumble

obrien-j commented 6 years ago

@lchski You mentioned you'd seen this before. Easy fix?

lchski commented 6 years ago

It’s a flexbox issue. Try changing .flex-1 to flex: 1 0 auto instead of just flex: 1, per https://stackoverflow.com/questions/21600345/flexbox-and-internet-explorer-11-displayflex-in-html.

I tested it quickly in the IE 11 inspector and it works there, but should verify it doesn’t mess up other browsers. Also I’m not sure where .flex-1 is declared, or I’d have done a PR 😛

evadb commented 6 years ago

thank you @lchski !

evadb commented 6 years ago

https://github.com/cds-snc/pulse/pull/123

late but fixed