search

cds-snc / report-a-cybercrime

Report a computer crime or scam / Signaler un crime informatique ou une fraude
https://report-a-scam.cds-snc.ca
MIT License
29 stars 14 forks source link

Should not leave blank after "and" word at summary page #2372

Closed lmcbhvu closed 4 years ago

lmcbhvu commented 4 years ago

Summary

If the user clicks all or some options before or after Other option in "How were your money or finances affected?" page, and don't put anything in the text area of other option. At summary page, it should not leave blank before and after "and" word at summary page. Currently, it shows "Method of Payment: E-transfer, Credit card, Gift card, Cryptocurrency, and " or "Method of Payment: and Cryptocurrency

image

image

Steps to reproduce

  1. Submit a report
  2. At page "How were your money or finances affected?", click all options but don't put anything in other text area OR click other option first and then the other options
  3. Complete the report until reach to summary page

Unresolved questions

Are there any related issues you consider out of scope for this issue that could be addressed in the future?

dengcn commented 4 years ago

This is a bug. it needs to get input from business team, If user clicked "Other", but did not type in anything in the input field, should we just remove ", and" in the summary/report or something else?

dengcn commented 4 years ago

Hong, here is how I fixed and implemented.

1) If clicked "Other", and have value in, like ："House" in "Other" Field. the summary looks like this:### XXXX, XXX, XXXXX and House

DemoPage_ClickedOtherAndHaveHouseFilled

2) If clicked "Other", and have no value filled in, and Others will be shown, since we need to reflect user clicked "Other" it looks like this DemoPage_ClickedOtherButNotValueFilled

Let me know if above are acceptable, thanks

lmcbhvu commented 4 years ago

I agree with your solution