cds-snc / report-a-cybercrime

Report a computer crime or scam / Signaler un crime informatique ou une fraude
https://report-a-scam.cds-snc.ca
MIT License
29 stars 14 forks source link

PR2372 Fix empty value after AND in summary #2384

Closed dengcn closed 4 years ago

dengcn commented 4 years ago

Fixes #2372 (issue)

Description

This is to fix empty value after AND in money lost part of summary when user did not fill in value in field but clicked the checkbox of "Other"

Please include a summary of the change.

Any new packages installed?

Give details

Required followup work

Is there anything related to this that still needs to be done (ex: documentation changes).

Checklist:

dengcn commented 4 years ago

The following scenario is agreed with Hong.

If clicked "Other", and have value in, like :"House" in "Other" Field. the summary looks like this:### XXXX, XXX, XXXXX and House DemoPage_ClickedOtherAndHaveHouseFilled

If clicked "Other", and have no value filled in, and Others will be shown, since we need to reflect user clicked "Other" it looks like this DemoPage_ClickedOtherButNotValueFilled

dengcn commented 4 years ago

If final display is "Other and Cryptocurrency”, this is acceptable. Because Other and Cryptocurrency are both valid categories