cds-snc / resources-ressources

Learning Resources / Ressources d'apprentissage
MIT License
3 stars 1 forks source link

[Release] Minor changes after soft launch #202

Closed daine closed 2 years ago

daine commented 2 years ago

Summary | RΓ©sumΓ©

This change adds a few minor changes to the site, and adds the google tag manager plugin.

⚠️ This PR can be tested through the following URL(s):

Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/

πŸš€ Release Checklist

Item Checked / Reviewed by Status Notes
Metrics - Google Analytics working and collecting data @daine @hillaryl Β  Not started Prioritized for next release
Content - Contentful Β  β˜€οΈ Ready Β 
Content - English @anikbrazeau β˜€οΈ Ready Β 
Content - French @anikbrazeau β˜€οΈ Ready
Infra - Domains OK @daine Β  β˜€οΈ Ready Β 
Infra - Amplify OK @daine β˜€οΈ Ready Β 
Monitoring (Uptime Robot) @daine β˜€οΈ Ready Β Status page dashboard
Accessibility - aXe DevTools @daine @dylanzheng94 Β  Not started Β 
Accessibility - Lighthouse checks @daine @dylanzheng94 Not started Β 
Accessibility - WCAG 2.0 AA @emanelfy Not started The intention is to achieve AAA for full launch
Infra - Content Security Policy @daine β˜€οΈ Ready Β 

After merge, do this:

From your terminal, make sure you are in the main branch, then type

git tag -a v0.2.0 -m <release notes>
git push --tags

This bumps up the release version

aws-amplify-ca-central-1[bot] commented 2 years ago

⚠️ This PR can be tested through the following URL(s):

Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/

daine commented 2 years ago

ci-v3 is failing -- that's the ci for nuxt3 which looks in the frontend folder so we should ignore it for now

github-actions[bot] commented 2 years ago

TF Plan for app

βœ…   Terraform Format: success βœ…   Terraform Plan: success βœ…   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_amplify_app.learning_resources_staging will be updated in-place ~ resource "aws_amplify_app" "learning_resources_staging" { ~ environment_variables = { + "GOOGLE_ANALYTICS_ID" = "" # (5 unchanged elements hidden) } id = "d3eik05156ec7t" name = "Learning Resources (Staging)" tags = {} # (16 unchanged attributes hidden) # (2 unchanged blocks hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.app"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_staging"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.staging"] WARN - plan.json - main - Missing Common Tags: ["aws_ecr_repository.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.app"] 29 tests, 17 passed, 12 warnings, 0 failures, 0 exceptions ```
aws-amplify-ca-central-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-202.d1aa42w7dd40bx.amplifyapp.com