cds-snc / resources-ressources

Learning Resources / Ressources d'apprentissage
MIT License
3 stars 1 forks source link

Fix/ci issues #204

Closed daine closed 2 years ago

daine commented 2 years ago

Summary | Résumé

Mostly lint fixes, some GH actions changes

github-actions[bot] commented 2 years ago

TF Plan for app

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_amplify_app.learning_resources_staging will be updated in-place ~ resource "aws_amplify_app" "learning_resources_staging" { ~ environment_variables = { + "GOOGLE_ANALYTICS_ID" = "" # Warning: this attribute value will be marked as sensitive and will not # display in UI output after applying this change. The value is unchanged. ~ "GOOGLE_TAG_MANAGER_ID" = (sensitive) # (4 unchanged elements hidden) } id = "d3eik05156ec7t" name = "Learning Resources (Staging)" tags = {} # (16 unchanged attributes hidden) # (2 unchanged blocks hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.app"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_staging"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.staging"] WARN - plan.json - main - Missing Common Tags: ["aws_ecr_repository.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.app"] 29 tests, 17 passed, 12 warnings, 0 failures, 0 exceptions ```
aws-amplify-ca-central-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-204.d3eik05156ec7t.amplifyapp.com