cds-snc / resources-ressources

Learning Resources / Ressources d'apprentissage
MIT License
3 stars 1 forks source link

[Release] Content Security Policy changes #221

Closed daine closed 2 years ago

daine commented 2 years ago

Summary | RΓ©sumΓ©

Changes to the content security policy

⚠️ This PR can be tested through the following URL(s):

Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/

πŸš€ Release Checklist

Item Checked / Reviewed by Status Notes
Metrics - Google Analytics working and collecting data @daine @hillaryl Β  β˜€οΈ Ready
Content - Contentful Β  Unchanged
Content - English @anikbrazeau Unchanged
Content - French @anikbrazeau Unchanged
Infra - Domains OK @daine Β  Unchanged
Infra - Amplify OK @daine Unchanged
Monitoring (Uptime Robot) @daine Unchanged Β Status page dashboard
Accessibility - aXe DevTools @daine @dylanzheng94 Β  Unchanged
Accessibility - Lighthouse checks @daine @dylanzheng94 Unchanged
Accessibility - WCAG 2.0 AA @emanelfy Unchanged The intention is to achieve AAA for full launch
Infra - Content Security Policy @daine β˜€οΈ Ready

After merge, do this:

From your terminal, make sure you are in the main branch, then type

git tag -a v0.2.0 -m <release notes>
git push --tags

This bumps up the release version

aws-amplify-ca-central-1[bot] commented 2 years ago

⚠️ This PR can be tested through the following URL(s): Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/

github-actions[bot] commented 2 years ago

TF Plan for app

βœ…   Terraform Format: success βœ…   Terraform Plan: success βœ…   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_amplify_app.learning_resources_staging will be updated in-place ~ resource "aws_amplify_app" "learning_resources_staging" { ~ environment_variables = { + "GOOGLE_ANALYTICS_ID" = "" # (5 unchanged elements hidden) } id = "d3eik05156ec7t" name = "Learning Resources (Staging)" tags = {} # (16 unchanged attributes hidden) # (2 unchanged blocks hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.app"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_staging"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.staging"] WARN - plan.json - main - Missing Common Tags: ["aws_ecr_repository.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.app"] 29 tests, 17 passed, 12 warnings, 0 failures, 0 exceptions ```