Closed daine closed 1 year ago
Access this pull request here:
Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-239.d1aa42w7dd40bx.amplifyapp.com
@dylanzheng94 @daine Wondering about ordering when it comes to jump to links. Should we consider putting them below H1 since they highlight all the H2s? What do you think?
Curious what the behavior might be if there are no H2s? Does the anchor link component, disappear in that use case?
Some issues we might want to tackle before releasing to production:
(@daine ~ adding more issues) Let's tackle this before we go to production
Found a suggestion for improving on accessibility:
@dylanzheng94 we can either submit a hotfix to address this, or create a ticket with high priority?
I wonder if it'd be possible to add some space/padding to the text when jumping to a particular section? For ease of readability, maybe it could be aligned with the start of "On this page" rather than the very top of the browser window?
Fixes #321
β
Terraform Format: success
β
Terraform Plan: success
β
Conftest: success
Plan: 3 to add, 2 to change, 0 to destroy
Summary | RΓ©sumΓ©
Included in this release:
β οΈ This PR can be tested through the following URL(s):
Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/
π Release Checklist
After merge, do this:
From your terminal, make sure you are in the
main
branch, then typeThis bumps up the release version