cds-snc / resources-ressources

Learning Resources / Ressources d'apprentissage
MIT License
3 stars 1 forks source link

[Release] Jumplinks, Resource Collections, Menu, Updated Documentation, Topic Sorting #239

Closed daine closed 1 year ago

daine commented 2 years ago

Summary | RΓ©sumΓ©

Included in this release:

⚠️ This PR can be tested through the following URL(s):

Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/

πŸš€ Release Checklist

Item Checked / Reviewed by Status Notes
Metrics - Google Analytics working and collecting data @daine @hillaryl Β  Not started
Content - Contentful Β  Not started
Content - English @anikbrazeau Not started
Content - French @anikbrazeau Not started
Infra - Domains OK @daine Β  β˜€οΈ Ready
Infra - Amplify OK @daine β˜€οΈ Ready
Monitoring (Uptime Robot) @daine β˜€οΈ Ready Β Status page dashboard
Accessibility - aXe DevTools @daine @dylanzheng94 Β  Not started
Accessibility - Lighthouse checks @daine @dylanzheng94 Not started
Accessibility - WCAG 2.0 AA @emanelfy Not started The intention is to achieve AAA for full launch
Infra - Content Security Policy @daine β˜€οΈ Ready

After merge, do this:

From your terminal, make sure you are in the main branch, then type

git tag -a v0.2.0 -m <release notes>
git push --tags

This bumps up the release version

aws-amplify-ca-central-1[bot] commented 2 years ago

Access this pull request here:

Main - https://staging.learning-resources.cdssandbox.xyz/ EN - https://en.staging.learning-resources.cdssandbox.xyz/ FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/

aws-amplify-ca-central-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-239.d1aa42w7dd40bx.amplifyapp.com

anikbrazeau commented 2 years ago

@dylanzheng94 @daine Wondering about ordering when it comes to jump to links. Should we consider putting them below H1 since they highlight all the H2s? What do you think?

Screen Shot 2022-09-13 at 5 25 16 PM
anikbrazeau commented 2 years ago

Curious what the behavior might be if there are no H2s? Does the anchor link component, disappear in that use case?

anikbrazeau commented 1 year ago

Some issues we might want to tackle before releasing to production:

(@daine ~ adding more issues) Let's tackle this before we go to production

daine commented 1 year ago

Found a suggestion for improving on accessibility:

Screen Shot 2022-09-21 at 10 25 08 AM Screen Shot 2022-09-21 at 10 31 44 AM

@dylanzheng94 we can either submit a hotfix to address this, or create a ticket with high priority?

anikbrazeau commented 1 year ago

I wonder if our pages that are longest, and might benefit most from the anchor "jump to" links, might actually be the Privacy and Terms pages? Food for thought.

Screen Shot 2022-09-21 at 4 37 33 PM Screen Shot 2022-09-21 at 4 37 40 PM
anikbrazeau commented 1 year ago

I wonder if it'd be possible to add some space/padding to the text when jumping to a particular section? For ease of readability, maybe it could be aligned with the start of "On this page" rather than the very top of the browser window?

Screen Shot 2022-09-21 at 9 59 16 PM

anikbrazeau commented 1 year ago

Fixes #321

github-actions[bot] commented 1 year ago

TF Plan for app

βœ…   Terraform Format: success βœ…   Terraform Plan: success βœ…   Conftest: success

Plan: 3 to add, 2 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: + create ~ update in-place Terraform will perform the following actions: # aws_amplify_app.learning_resources will be updated in-place ~ resource "aws_amplify_app" "learning_resources" { ~ environment_variables = { + "SENTRY_DSN" = (sensitive) # (6 unchanged elements hidden) } id = "d1aa42w7dd40bx" name = "learning-app" tags = {} # (16 unchanged attributes hidden) # (2 unchanged blocks hidden) } # aws_amplify_app.learning_resources_nuxt3 will be created + resource "aws_amplify_app" "learning_resources_nuxt3" { + access_token = (sensitive value) + arn = (known after apply) + auto_branch_creation_patterns = [ + "ci*", + "feature*/", + "fix*", + "release*", ] + build_spec = <<-EOT version: 1 frontend: phases: preBuild: commands: - cd frontend - cp .contentful.json.sample .contentful.json - nvm use $VERSION_NODE_16 build: commands: - nvm use $VERSION_NODE_16 - node -v - npm run generate artifacts: baseDirectory: frontend/.output/public files: - '**/*' cache: paths: - node_modules/**/* EOT + default_domain = (known after apply) + enable_auto_branch_creation = true + enable_branch_auto_deletion = true + environment_variables = { + "ENV" = "staging" + "contentful_cda_access_token" = (sensitive) } + id = (known after apply) + name = "learning-app-nuxt3" + platform = "WEB" + production_branch = (known after apply) + repository = "https://github.com/cds-snc/resources-ressources" + tags_all = (known after apply) + auto_branch_creation_config { + enable_auto_build = true + enable_pull_request_preview = true + pull_request_environment_name = "pr" + stage = "PULL_REQUEST" } + custom_rule { + source = "/<*>" + status = "404" + target = "/index.html" } } # aws_amplify_app.learning_resources_staging will be updated in-place ~ resource "aws_amplify_app" "learning_resources_staging" { ~ environment_variables = { + "GOOGLE_ANALYTICS_ID" = "" + "SENTRY_DSN" = (sensitive) # (5 unchanged elements hidden) } id = "d3eik05156ec7t" name = "Learning Resources (Staging)" tags = {} # (16 unchanged attributes hidden) # (2 unchanged blocks hidden) } # aws_amplify_branch.nuxt3 will be created + resource "aws_amplify_branch" "nuxt3" { + app_id = (known after apply) + arn = (known after apply) + associated_resources = (known after apply) + branch_name = "nuxt3" + custom_domains = (known after apply) + destination_branch = (known after apply) + display_name = "beta" + enable_auto_build = true + enable_pull_request_preview = true + framework = "Nuxt3" + id = (known after apply) + pull_request_environment_name = "PULL_REQUEST" + source_branch = (known after apply) + stage = "BETA" + tags_all = (known after apply) } # aws_amplify_domain_association.learning_resources_nuxt3 will be created + resource "aws_amplify_domain_association" "learning_resources_nuxt3" { + app_id = (known after apply) + arn = (known after apply) + certificate_verification_dns_record = (known after apply) + domain_name = "v3.learning-resources.cdssandbox.xyz" + id = (known after apply) + wait_for_verification = false + sub_domain { + branch_name = "nuxt3" + dns_record = (known after apply) + verified = (known after apply) } + sub_domain { + branch_name = "nuxt3" + dns_record = (known after apply) + prefix = "en" + verified = (known after apply) } + sub_domain { + branch_name = "nuxt3" + dns_record = (known after apply) + prefix = "fr" + verified = (known after apply) } + sub_domain { + branch_name = "nuxt3" + dns_record = (known after apply) + prefix = "www" + verified = (known after apply) } } Plan: 3 to add, 2 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" Releasing state lock. This may take a few moments... ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.app"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_staging"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.staging"] WARN - plan.json - main - Missing Common Tags: ["aws_ecr_repository.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.app"] 29 tests, 17 passed, 12 warnings, 0 failures, 0 exceptions ```