Closed realdylanzheng closed 2 years ago
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-242.d3eik05156ec7t.amplifyapp.com
This looks good! Curious how it shows up on the French side? Is there enough room for it on the same line as the title and "Français"? Might we want to have those show up one above the other on smaller screens / mobile?
What is the ordering principle we're using for topics / menu? Looks like perhaps we're presenting the latest updated first which could lead to constant reshuffling?
Could we make it a more predictable alphabetical order perhaps for now, for each of EN and FR, both in the menu and on the homepage itself?
Fixes #241
Looks like the spacing does become an issue in French. Perhaps we could have the menu shift to below the heading or something on mobile/narrow screens?
For future consideration/thought π€ I wonder if there might be a way to think through the parallelism, hierachy, relationship and potential for more interaction between "Menu" / "breadcrumb" / H1 / "On this page". Might there be a way to unite these to be more cohesive?
FYI, this is the french link to test: https://fr.pr-242.staging.learning-resources.cdssandbox.xyz/ The language switcher won't work correctly as I haven't updated the environment variables, but the english version is also accessible here: https://pr-242.staging.learning-resources.cdssandbox.xyz/
π Linked issue
β Type of change
π Description
π Checklist
[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.