cds-snc / resources-ressources

Learning Resources / Ressources d'apprentissage
MIT License
3 stars 1 forks source link

WIP Contentful preview #249

Closed daine closed 2 years ago

daine commented 2 years ago

🔗 Linked issue

230

243

❓ Type of change

📚 Description

This PR fixes a bug in local development that can't resolve locales This PR also adds in the ability to query the contentful preview API and apply the pulled content when ran locally

Noted issues:

📝 Checklist

aws-amplify-ca-central-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-249.d3eik05156ec7t.amplifyapp.com

github-actions[bot] commented 2 years ago

TF Plan for app

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

Plan: 0 to add, 2 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_amplify_app.learning_resources will be updated in-place ~ resource "aws_amplify_app" "learning_resources" { ~ environment_variables = { + "SENTRY_DSN" = (sensitive) # (6 unchanged elements hidden) } id = "d1aa42w7dd40bx" name = "learning-app" tags = {} # (16 unchanged attributes hidden) # (2 unchanged blocks hidden) } # aws_amplify_app.learning_resources_staging will be updated in-place ~ resource "aws_amplify_app" "learning_resources_staging" { ~ environment_variables = { + "GOOGLE_ANALYTICS_ID" = "" + "SENTRY_DSN" = (sensitive) # (5 unchanged elements hidden) } id = "d3eik05156ec7t" name = "Learning Resources (Staging)" tags = {} # (16 unchanged attributes hidden) # (2 unchanged blocks hidden) } Plan: 0 to add, 2 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.app"] WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_staging"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main_storybook"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.nuxt3"] WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.staging"] WARN - plan.json - main - Missing Common Tags: ["aws_ecr_repository.learning_resources"] WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.app"] 29 tests, 17 passed, 12 warnings, 0 failures, 0 exceptions ```
daine commented 2 years ago

Closing this PR for now ~ work is paused