cds-snc / simplify-privacy-statements-V2

starter-app repo based version of privacy app.
https://simplify-privacy-statements.alpha.canada.ca
MIT License
5 stars 1 forks source link

updated efs #246

Closed omartehsin1 closed 1 year ago

omartehsin1 commented 1 year ago

Summary | Résumé

1-3 sentence description of the changed you're proposing, including a link to a GitHub Issue # or Trello card if applicable.


Description en 1 à 3 phrases de la modification proposée, avec un lien vers le problème (« issue ») GitHub ou la fiche Trello, le cas échéant.

Test instructions | Instructions pour tester la modification

Sequential steps (1., 2., 3., ...) that describe how to test this change. This will help a developer test things out without too much detective work. Also, include any environmental setup steps that aren't in the normal README steps and/or any time-based elements that this requires.


Étapes consécutives (1., 2., 3., …) qui décrivent la façon de tester la modification. Elles aideront les développeurs à faire des tests sans avoir à jouer au détective. Veuillez aussi inclure toutes les étapes de configuration de l’environnement qui ne font pas partie des étapes normales dans le fichier README et tout élément temporel requis.

github-actions[bot] commented 1 year ago

Production: vpc

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success ⚠️   WARNING: resources will be destroyed by this change!

Plan: 2 to add, 0 to change, 2 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # aws_security_group.efs_access_sg must be replaced -/+ resource "aws_security_group" "efs_access_sg" { ~ arn = "arn:aws:ec2:ca-central-1:414662622316:security-group/sg-033c29e939a74c39b" -> (known after apply) ~ description = "SG for Lambda" -> "SG for EFS" # forces replacement ~ egress = [] -> (known after apply) ~ id = "sg-033c29e939a74c39b" -> (known after apply) ~ ingress = [ - { - cidr_blocks = [] - description = "Enables inbound traffic to the Network File System" - from_port = 2049 - ipv6_cidr_blocks = [] - prefix_list_ids = [] - protocol = "tcp" - security_groups = [ - "sg-078714ea1197f9904", ] - self = false - to_port = 2049 }, ] -> (known after apply) name = "efs_access_sg" + name_prefix = (known after apply) ~ owner_id = "414662622316" -> (known after apply) - tags = {} -> null ~ tags_all = {} -> (known after apply) # (2 unchanged attributes hidden) } # aws_security_group_rule.efs_ingress must be replaced -/+ resource "aws_security_group_rule" "efs_ingress" { ~ id = "sgrule-1432948669" -> (known after apply) ~ security_group_id = "sg-033c29e939a74c39b" -> (known after apply) # forces replacement ~ security_group_rule_id = "sgr-00f665de9934ff94f" -> (known after apply) # (7 unchanged attributes hidden) } Plan: 2 to add, 0 to change, 2 to destroy. Changes to Outputs: + private_subnets_ids = [ + "subnet-0eb6100fb7b928309", + "subnet-0ff73a0b898dee7d3", + "subnet-0bab694b39aeddc27", ] ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_security_group.efs_access_sg"] WARN - plan.json - main - Missing Common Tags: ["aws_security_group.lambda_access_sg"] 19 tests, 17 passed, 2 warnings, 0 failures, 0 exceptions ```
github-actions[bot] commented 1 year ago

Production: efs

❌   Terraform Format: failed ❌   Terraform Plan: failed ❌   Conftest: failed

Show plan ```terraform time=2023-03-24T19:06:32Z level=error msg=/home/runner/work/simplify-privacy-statements-V2/simplify-privacy-statements-V2/terragrunt/env/production/efs/terragrunt.hcl:20,50-70: Unsupported attribute; This object does not have an attribute named "private_subnets_ids". time=2023-03-24T19:06:32Z level=error msg=Unable to determine underlying exit code, so Terragrunt will exit with error code 1 ```
github-actions[bot] commented 1 year ago

Production: app

❌   Terraform Format: failed ❌   Terraform Plan: failed ❌   Conftest: failed

Show plan ```terraform time=2023-03-24T19:12:24Z level=error msg=/home/runner/work/simplify-privacy-statements-V2/simplify-privacy-statements-V2/terragrunt/env/production/efs/terragrunt.hcl:14,6-7: Invalid expression; Expected the start of an expression, but found an invalid expression token. time=2023-03-24T19:12:24Z level=error msg=Unable to determine underlying exit code, so Terragrunt will exit with error code 1 ```