cds-snc / simplify-privacy-statements-V2

starter-app repo based version of privacy app.
https://simplify-privacy-statements.alpha.canada.ca
MIT License
5 stars 1 forks source link

update/added-private-subnet-output-id #247

Closed omartehsin1 closed 1 year ago

omartehsin1 commented 1 year ago

Summary | Résumé

Output for Private Subnet IDs

github-actions[bot] commented 1 year ago

Production: vpc

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success ⚠️   WARNING: resources will be destroyed by this change!

Plan: 2 to add, 0 to change, 2 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # aws_security_group.efs_access_sg must be replaced -/+ resource "aws_security_group" "efs_access_sg" { ~ arn = "arn:aws:ec2:ca-central-1:414662622316:security-group/sg-033c29e939a74c39b" -> (known after apply) ~ description = "SG for Lambda" -> "Security Group for EFS" # forces replacement ~ egress = [] -> (known after apply) ~ id = "sg-033c29e939a74c39b" -> (known after apply) ~ ingress = [ - { - cidr_blocks = [] - description = "Enables inbound traffic to the Network File System" - from_port = 2049 - ipv6_cidr_blocks = [] - prefix_list_ids = [] - protocol = "tcp" - security_groups = [ - "sg-078714ea1197f9904", ] - self = false - to_port = 2049 }, ] -> (known after apply) name = "efs_access_sg" + name_prefix = (known after apply) ~ owner_id = "414662622316" -> (known after apply) - tags = {} -> null ~ tags_all = {} -> (known after apply) # (2 unchanged attributes hidden) } # aws_security_group_rule.efs_ingress must be replaced -/+ resource "aws_security_group_rule" "efs_ingress" { ~ id = "sgrule-1432948669" -> (known after apply) ~ security_group_id = "sg-033c29e939a74c39b" -> (known after apply) # forces replacement ~ security_group_rule_id = "sgr-00f665de9934ff94f" -> (known after apply) # (7 unchanged attributes hidden) } Plan: 2 to add, 0 to change, 2 to destroy. Changes to Outputs: + private_subnet_ids = [ + "subnet-0eb6100fb7b928309", + "subnet-0ff73a0b898dee7d3", + "subnet-0bab694b39aeddc27", ] ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_security_group.efs_access_sg"] WARN - plan.json - main - Missing Common Tags: ["aws_security_group.lambda_access_sg"] 19 tests, 17 passed, 2 warnings, 0 failures, 0 exceptions ```
github-actions[bot] commented 1 year ago

Production: efs

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

Plan: 0 to add, 3 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_efs_mount_target.efs_mount[0] will be updated in-place ~ resource "aws_efs_mount_target" "efs_mount" { id = "fsmt-05790746dea8040ca" ~ security_groups = [ - "sg-033c29e939a74c39b", + "sg-078714ea1197f9904", ] # (10 unchanged attributes hidden) } # aws_efs_mount_target.efs_mount[1] will be updated in-place ~ resource "aws_efs_mount_target" "efs_mount" { id = "fsmt-0e09b4cf05d121f19" ~ security_groups = [ - "sg-033c29e939a74c39b", + "sg-078714ea1197f9904", ] # (10 unchanged attributes hidden) } # aws_efs_mount_target.efs_mount[2] will be updated in-place ~ resource "aws_efs_mount_target" "efs_mount" { id = "fsmt-0828a7bb0921bd904" ~ security_groups = [ - "sg-033c29e939a74c39b", + "sg-078714ea1197f9904", ] # (10 unchanged attributes hidden) } Plan: 0 to add, 3 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_efs_access_point.efs_access_point"] WARN - plan.json - main - Missing Common Tags: ["aws_efs_file_system.generated_statement_efs"] 19 tests, 17 passed, 2 warnings, 0 failures, 0 exceptions ```