cds-snc / simplify-privacy-statements-V2

starter-app repo based version of privacy app.
https://simplify-privacy-statements.alpha.canada.ca
MIT License
5 stars 1 forks source link

updated efs subnet #248

Closed omartehsin1 closed 1 year ago

omartehsin1 commented 1 year ago

Summary | Résumé

Still getting Timeout errors, moved lambda into the private subnet to see if it helps

github-actions[bot] commented 1 year ago

Production: efs

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success ⚠️   WARNING: resources will be destroyed by this change!

Plan: 3 to add, 0 to change, 3 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # aws_efs_mount_target.efs_mount[0] must be replaced -/+ resource "aws_efs_mount_target" "efs_mount" { ~ availability_zone_id = "cac1-az1" -> (known after apply) ~ availability_zone_name = "ca-central-1a" -> (known after apply) ~ dns_name = "fs-0ee57b8f2b2e8fe38.efs.ca-central-1.amazonaws.com" -> (known after apply) ~ file_system_arn = "arn:aws:elasticfilesystem:ca-central-1:414662622316:file-system/fs-0ee57b8f2b2e8fe38" -> (known after apply) ~ id = "fsmt-063b261553c7fe192" -> (known after apply) ~ ip_address = "10.0.3.166" -> (known after apply) ~ mount_target_dns_name = "ca-central-1a.fs-0ee57b8f2b2e8fe38.efs.ca-central-1.amazonaws.com" -> (known after apply) ~ network_interface_id = "eni-03c95da0d5a4156cb" -> (known after apply) ~ owner_id = "414662622316" -> (known after apply) ~ subnet_id = "subnet-066c6b13009cc761a" -> "subnet-0eb6100fb7b928309" # forces replacement # (2 unchanged attributes hidden) } # aws_efs_mount_target.efs_mount[1] must be replaced -/+ resource "aws_efs_mount_target" "efs_mount" { ~ availability_zone_id = "cac1-az2" -> (known after apply) ~ availability_zone_name = "ca-central-1b" -> (known after apply) ~ dns_name = "fs-0ee57b8f2b2e8fe38.efs.ca-central-1.amazonaws.com" -> (known after apply) ~ file_system_arn = "arn:aws:elasticfilesystem:ca-central-1:414662622316:file-system/fs-0ee57b8f2b2e8fe38" -> (known after apply) ~ id = "fsmt-05e315ca19321a7d8" -> (known after apply) ~ ip_address = "10.0.4.27" -> (known after apply) ~ mount_target_dns_name = "ca-central-1b.fs-0ee57b8f2b2e8fe38.efs.ca-central-1.amazonaws.com" -> (known after apply) ~ network_interface_id = "eni-0d138a8098c154e28" -> (known after apply) ~ owner_id = "414662622316" -> (known after apply) ~ subnet_id = "subnet-0f0e20195a44b2a73" -> "subnet-0ff73a0b898dee7d3" # forces replacement # (2 unchanged attributes hidden) } # aws_efs_mount_target.efs_mount[2] must be replaced -/+ resource "aws_efs_mount_target" "efs_mount" { ~ availability_zone_id = "cac1-az4" -> (known after apply) ~ availability_zone_name = "ca-central-1d" -> (known after apply) ~ dns_name = "fs-0ee57b8f2b2e8fe38.efs.ca-central-1.amazonaws.com" -> (known after apply) ~ file_system_arn = "arn:aws:elasticfilesystem:ca-central-1:414662622316:file-system/fs-0ee57b8f2b2e8fe38" -> (known after apply) ~ id = "fsmt-08955648569fc5606" -> (known after apply) ~ ip_address = "10.0.5.220" -> (known after apply) ~ mount_target_dns_name = "ca-central-1d.fs-0ee57b8f2b2e8fe38.efs.ca-central-1.amazonaws.com" -> (known after apply) ~ network_interface_id = "eni-0d2b8f477e97f610b" -> (known after apply) ~ owner_id = "414662622316" -> (known after apply) ~ subnet_id = "subnet-04892391188217b74" -> "subnet-0bab694b39aeddc27" # forces replacement # (2 unchanged attributes hidden) } Plan: 3 to add, 0 to change, 3 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" Releasing state lock. This may take a few moments... ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_efs_access_point.efs_access_point"] WARN - plan.json - main - Missing Common Tags: ["aws_efs_file_system.generated_statement_efs"] 19 tests, 17 passed, 2 warnings, 0 failures, 0 exceptions ```
github-actions[bot] commented 1 year ago

Production: app

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # module.generated_statement_lambda.aws_lambda_function.this will be updated in-place ~ resource "aws_lambda_function" "this" { id = "generated_statement_lambda_function" tags = { "CostCentre" = "simplify-privacy-statements-production" "Terraform" = "true" } # (20 unchanged attributes hidden) ~ vpc_config { ~ subnet_ids = [ - "subnet-04892391188217b74", - "subnet-066c6b13009cc761a", + "subnet-0bab694b39aeddc27", + "subnet-0eb6100fb7b928309", - "subnet-0f0e20195a44b2a73", + "subnet-0ff73a0b898dee7d3", ] # (2 unchanged attributes hidden) } # (4 unchanged blocks hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" Releasing state lock. This may take a few moments... ```
Show Conftest results ```sh 18 tests, 18 passed, 0 warnings, 0 failures, 0 exceptions ```