cds-snc / simplify-privacy-statements-V2

starter-app repo based version of privacy app.
https://simplify-privacy-statements.alpha.canada.ca
MIT License
5 stars 1 forks source link

bug/update-sg-variable #252

Closed omartehsin1 closed 1 year ago

omartehsin1 commented 1 year ago

Summary | Résumé

Added EFS Security group variable, changed reference on efs resource

github-actions[bot] commented 1 year ago

Production: vpc

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

Plan: 0 to add, 0 to change, 0 to destroy
Show plan ```terraform Changes to Outputs: - aws_security_group_ids = "sg-078714ea1197f9904" -> null You can apply this plan to save these new output values to the Terraform state, without changing any real infrastructure. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" Releasing state lock. This may take a few moments... ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_security_group.efs_access_sg"] WARN - plan.json - main - Missing Common Tags: ["aws_security_group.lambda_access_sg"] 19 tests, 17 passed, 2 warnings, 0 failures, 0 exceptions ```
github-actions[bot] commented 1 year ago

Production: efs

✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

Plan: 0 to add, 3 to change, 0 to destroy
Show plan ```terraform Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_efs_mount_target.efs_mount[0] will be updated in-place ~ resource "aws_efs_mount_target" "efs_mount" { id = "fsmt-0d075a2419cec218d" ~ security_groups = [ + "sg-03097253ad9dae1d8", - "sg-078714ea1197f9904", ] # (10 unchanged attributes hidden) } # aws_efs_mount_target.efs_mount[1] will be updated in-place ~ resource "aws_efs_mount_target" "efs_mount" { id = "fsmt-0860bf956647ae644" ~ security_groups = [ + "sg-03097253ad9dae1d8", - "sg-078714ea1197f9904", ] # (10 unchanged attributes hidden) } # aws_efs_mount_target.efs_mount[2] will be updated in-place ~ resource "aws_efs_mount_target" "efs_mount" { id = "fsmt-01758a561676287b6" ~ security_groups = [ + "sg-03097253ad9dae1d8", - "sg-078714ea1197f9904", ] # (10 unchanged attributes hidden) } Plan: 0 to add, 3 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" Releasing state lock. This may take a few moments... ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_efs_access_point.efs_access_point"] WARN - plan.json - main - Missing Common Tags: ["aws_efs_file_system.generated_statement_efs"] 19 tests, 17 passed, 2 warnings, 0 failures, 0 exceptions ```