cds-snc / url-shortener

An API written in Python that shortens URLs
MIT License
4 stars 0 forks source link

fix: set cookie `secure=True` attribute #371

Closed patheard closed 1 year ago

patheard commented 1 year ago

Summary

Update the cookie so that it can no longer sent in plaintext with unecrypted requests.

Related

patheard commented 1 year ago

I double checked and everything is working nicely for me locally: Screenshot 2023-05-11 at 9 03 57 AM

The Mozilla dev docs are also saying this is expected so perhaps it is a newer browser thing to allow it: https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#restrict_access_to_cookies