Research and decide the screen size of mobile + refactor the code to be consistent

cds-snc / vac-benefits-directory

Find benefits and services (at time of handoff)

https://vac-handoff.herokuapp.com/

MIT License

1 stars 1 forks source link

Research and decide the screen size of mobile + refactor the code to be consistent #15

Open smcmurtry opened 5 years ago

smcmurtry commented 5 years ago

Issue by SupeDeDupe Thursday Jan 24, 2019 at 16:20 GMT Originally opened as https://github.com/veteransaffairscanada/vac-benefits-directory/issues/1746

The breakpoints are not all consistent for mobile screens throughout the code. Sometimes globalTheme.max.xs is used and sometimes globalTheme.max.mobile is used. sm is also used in some spots.

smcmurtry commented 5 years ago

Comment by smcmurtry Monday Mar 18, 2019 at 18:20 GMT

I think this has been resolved by adopting the breakpoints from veterans.gc.ca. Is it okay if we close this @SupeDeDupe?