search

cdsap / Talaiot

Simple and extensible plugin to track task times in your Gradle Project.
MIT License
584 stars 37 forks source link

Custom publishers in 2.x #399

Open TWiStErRob opened 1 month ago

TWiStErRob commented 1 month ago

Hey, it seems 2.0 removed custom publisher configuration.

The documentation is still showing the old API (including a typo with plural): https://github.com/cdsap/Talaiot/wiki/Publishers#custompublisher

How do we do the same in 2.x in .gradle.kts?

TWiStErRob commented 3 weeks ago

I think the issue might be visibility:

https://github.com/cdsap/Talaiot/blob/33a6e36c798686630308252eed1fc8f68c623fa6/library/plugins/base/base-plugin/src/main/java/io/github/cdsap/talaiot/plugin/base/BaseConfiguration.kt#L8

extends

https://github.com/cdsap/Talaiot/blob/33a6e36c798686630308252eed1fc8f68c623fa6/library/core/talaiot/src/main/kotlin/io/github/cdsap/talaiot/publisher/PublishersConfiguration.kt#L5

which means BaseConfiguration's API contains the superclass PublishersConfiguration. but it's not exposed as a dependency (api(...)):

https://github.com/cdsap/Talaiot/blob/33a6e36c798686630308252eed1fc8f68c623fa6/library/plugins/base/base-plugin/build.gradle.kts#L17