search

cdsteinkuehler / br2rauc

Buildroot + RAUC
Other
51 stars 18 forks source link

Update README.md #28

Closed isius closed 2 weeks ago

isius commented 3 weeks ago

Fix fw_dtb typos

cdsteinkuehler commented 3 weeks ago

Why do you feel quotes are required around fw_dtb and that it is a typo that they are not present?

I can see an argument that fw_dtb should be flagged as code in the markdown, eg: fw_dtb (using back-tick single quotes), but I don't see why double-quotes are desired.

isius commented 3 weeks ago

Initially I fixed only the typos of "fw_dft" (which I spent way too much time trying to find reference to) on lines 327 and 340.

Along the way I figured I'd match the existing "fw_dtb" (with quotes) on line 251.

Per your suggestion, I agree that back ticks would be preferrable.

cdsteinkuehler commented 2 weeks ago

Thanks! I didn't notice the fw_dtb/fw_dft typo, and being consistent with the quotes is a good thing. Thanks for the contribution!