search

cdukes / bones-for-genesis-2-0

A starting point for new Genesis projects. Built for Genesis 3.* and WordPress 5.*+.
GNU General Public License v3.0
182 stars 61 forks source link

Better way of handling IE conditional comments and CHILD_THEME_VERSION for versioning #10

Closed EmilEriksen closed 10 years ago

EmilEriksen commented 10 years ago

Hi,

Thanks for this great starting point! I was wondering why you created the function bfg_ie_conditionals when you can use WordPress for this? http://kuttler.eu/post/wordpress-style-version-conditional-comments/

And also why you are using null instead of versioning assets with CHILD_THEME_VERSION?

cdukes commented 10 years ago

Hi,

I wasn't aware of this trick - thanks for the tip. However, I did a quick test, and it doesn't look like it supports <!--[if !IE]> --> <!--[if gte IE 8]> to let the main stylesheet be used in IE8+ and all other browsers (excluding IE7-). Or am I not doing it right? Keep in mind that the main stylesheet has to be listed twice in the .

Not versioning assets is just personal preference. With in-development projects, I don't update the child theme version for every commit. I'd rather know there's no version string on the assets, than have it be there half the time.

Thanks!

EmilEriksen commented 10 years ago

Hi,

Thanks for the reply! You're right; I don't think it can be listed twice either.

Okay, fair enough :)