cdvntr / react-native-confetti

Raining confetti made with react native animations
MIT License
221 stars 55 forks source link

stopConfetti doesn't exist #6

Closed ghost closed 7 years ago

ghost commented 7 years ago

I was having issues with using stopConfetti() from the docs, it simply didn't exist. Then I realised that the code implementing it doesn't yet exist in my local copy from NPM (0.0.4).

screen shot 2017-05-12 at 10 21 59

Would simple bump and publish solve this issue? I'd be happy to help, but not sure if I can.

Thanks for this package, as well as help with this!

j-mendez commented 7 years ago

@adambubenicek change the function name from stoConfetti to stopConfettiAnimation in the lib and use stopConfettiAnimation and it will work. Im not sure why he named the function the same as the class variable bool LOL.

kolyan94 commented 7 years ago

@adambubenicek you can simply set value true and it'll work. this._confettiView.stopConfetti = true;

ghost commented 7 years ago

Thanks guys, created a PR to fix the naming conflict https://github.com/cdvntr/react-native-confetti/pull/11

Slightly off topic topic – initially I think the problem was that NPM version was outdated (didn't have stopConfetti method nor flag). That is now fixed since NPM version is at 0.0.5, although package.json still is at 0.0.4

cdvntr commented 7 years ago

Hey,

Package.json and npm are both up to date atm.

ghost commented 7 years ago

Awesome, thanks @cdvntr !