search

cea-hpc / milkcheck

Highly parallel and flexible service manager.
Other
23 stars 6 forks source link

Add python3 support #50

Closed cedeyn closed 4 years ago

cedeyn commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@15aa224). Click here to learn what that means. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage          ?   99.55%           
=========================================
  Files             ?       22           
  Lines             ?     4944           
  Branches          ?        0           
=========================================
  Hits              ?     4922           
  Misses            ?       22           
  Partials          ?        0
Impacted Files Coverage Δ
tests/MilkCheckTests/ServiceManagerTest.py 100.00% <ø> (ø)
lib/MilkCheck/UI/Cli.py 96.26% <33.33%> (ø)
lib/MilkCheck/Engine/Action.py 100.00% <100.00%> (ø)
lib/MilkCheck/Engine/BaseEntity.py 99.45% <100.00%> (ø)
lib/MilkCheck/Engine/ServiceGroup.py 96.69% <100.00%> (ø)
lib/MilkCheck/ServiceManager.py 100.00% <100.00%> (ø)
tests/MilkCheckTests/EngineTests/ActionTest.py 100.00% <100.00%> (ø)
tests/MilkCheckTests/UITests/CliTest.py 100.00% <100.00%> (ø)
tests/MilkCheckTests/__init__.py 100.00% <100.00%> (ø)
tests/MilkCheckTests/configtests.py 100.00% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15aa224...baafd1b. Read the comment docs.

degremont commented 4 years ago

one last change, otherwise LGTM