cea-hpc / modules

Environment Modules: provides dynamic modification of a user's environment
http://modules.sourceforge.net/
GNU General Public License v2.0
668 stars 102 forks source link

ci(lint): add shell linter - Differential ShellCheck #469

Closed jamacku closed 1 year ago

jamacku commented 1 year ago

Differential ShellCheck is a GitHub action that performs differential ShellCheck scans on shell scripts changed via PR and reports results directly in PR.

I saw that your scripts are in great shape, but I think that you might find differential-shellcheck action useful. It is able to produce reports in SARIF format. GitHub understands this format and is able to display it nicely as a PR comment, and on the Files Changed tab, please see below.

image

image

Documentation is available at @redhat-plumbers-in-action/differential-shellcheck. Let me know If you are missing some feature or setting. I'm always happy to extend functionality.

/cc @lzaoral

codecov[bot] commented 1 year ago

Codecov Report

Merging #469 (d7b498d) into master (b202ea8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          12       12           
  Lines        4754     4754           
=======================================
  Hits         4678     4678           
  Misses         76       76           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

xdelaruelle commented 1 year ago

This is a nice addition. Thank you very much for your contribution.