search

cea-hpc / modules

Environment Modules: provides dynamic modification of a user's environment
http://modules.sourceforge.net/
GNU General Public License v2.0
716 stars 109 forks source link

MODULEPATH aware module-tag use #485

Closed wenzler closed 1 year ago

wenzler commented 1 year ago

Is your feature request related to a problem? Please describe.

No. But module-tag requires not a file name but module name/alias as parameter. Thus it is not aware of the same module name being available in a different MODULEPATH repos.

Describe the solution you'd like

Allow definition of the actual filename (as in module display) module-tag "Patched" /root/common/modules/git/1.0

Would also be good to have the tags displayed in the module display output ,btw :)

Describe alternatives you've considered

Joining the space marines to seek out new life and new civilizations

Additional context

Tested in 5.2.0

Thanks!

xdelaruelle commented 1 year ago

Could you provide an exemple setup (with initrc) to test such high loading time?

Regards, Xavier

Le jeu. 2 mars 2023 à 10:04, ωєиzℓєя @.***> a écrit :

The module-tag via etc/initrc has also high impact on the loading time of modules With 1300 modules tagged, it increases from 40ms to 120ms

This should only affect module list and module avail commands.

— Reply to this email directly, view it on GitHub https://github.com/cea-hpc/modules/issues/485#issuecomment-1451525907, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFTKVN66WF2NG5EXLW26TDW2BPBBANCNFSM6AAAAAAVF4G7Q4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

xdelaruelle commented 1 year ago

Comment about performance issue has been removed so I assume this issue has been solved on your side. If you still have an issue, please open a separate ticket to distinguish from this feature request.

script/mb utility from this git repository helps to know the performance one can expect from various sub-commands.

wenzler commented 1 year ago

Hey, sorry for late response performance only suffers with thousands of different tags Had added one module-tag line per module with identical tags first ;)

Would still be nice to have the module-tag accept MODULEPATH specific arguments like stated above

Cheers

xdelaruelle commented 1 year ago

Ability to specify modules with their full path file name on module-tag, module-hide and module-forbid has been developed. It will be part of the next feature release (5.4) that I plan to publish before the end of this year. Code will be integrated to main git branch once 5.3.1 bugfix release will be published.