Scheduler period_ms parameter ignored

cea-hpc / robinhood

Robinhood Policy Engine : a versatile tool to monitor filesystem contents and schedule actions on filesystem entries.

http://robinhood.sf.net

Other

181 stars 62 forks source link

Scheduler period_ms parameter ignored #102

Closed dtcray closed 5 years ago

dtcray commented 5 years ago

Robinhood config read seem to ignore period_ms option and always set this to 1000ms (default). there seem to be a parameter inconsistency in sched_ratelimit.c lines 235-239. lines 235 uses "period_ms" (allowed parameters) line 239 uses "period" (tbf_params)

tl-cea commented 5 years ago

Thank you for pointing this out. This explains some incorrect rate limitations i've seen.

tl-cea commented 5 years ago

Thank you for the fix https://review.gerrithub.io/c/cea-hpc/robinhood/+/437807 It looks good. Sorry for the integration delay. The test/validation platform is currently under heavy reconstruction. It will take some time to get it back.

tl-cea commented 5 years ago

Fixed in 3.1.5