search

cea-hpc / robinhood

Robinhood Policy Engine : a versatile tool to monitor filesystem contents and schedule actions on filesystem entries.
http://robinhood.sf.net
Other
177 stars 60 forks source link

WIP: add Lustre project ID support #122

Closed thiell closed 1 year ago

thiell commented 2 years ago

Add new column projid to table ENTRIES (with default value 0).

Add projid support to scan and changelogs (on CL_CREATE and CL_SETATTR).

Add --split-user-projects/-J option to rbh-report.

Change-Id: If66ba9d21f522830650f428dd846c27052ad89dd

tl-cea commented 2 years ago

Hello Stephane, This is a work in progress in rbh4. Best regards, Thomas

tl-cea commented 2 years ago

Hello Stephane, This is a work in progress in rbh4. Best regards, Thomas

Sorry. I Just realized that this was not a request for feature but actually a patch proposal :) Usually, we process the reviews on gerrithub: https://review.gerrithub.io/q/project:cea-hpc%252Frobinhood

thiell commented 2 years ago

Thanks Thomas! It's still a WIP because I was a bit unsure of how to do it and also in parallel, I'm testing it on Oak. I will soon launch a large scan with this patch to populate the projid column. With 2B inodes, this should be a good test. :)

tl-cea commented 2 years ago

Dear Stephan, did you try with the O_PATH and did you notice a difference?

tl-cea commented 2 years ago

Very good! It sounds the feature is now ready for integration to the next release?

thiell commented 2 years ago

Yep! Feel free to squash all these commits into a single one. Thanks for the review! In the future, when Lustre supports it, we could easily add support for symlink.

tl-cea commented 2 years ago

Squashed and pushed to gerrithub for more in-depth review and testing: https://review.gerrithub.io/c/cea-hpc/robinhood/+/541104/

Thank you for this excellent and useful contribution!

tl-cea commented 2 years ago

I noticed that you started implementing proj_id triggers, but the patch doesn't contain a way to use it: it does not support "projid" triggers from configuration, and there is no way to run a policy by projid from the command line. What is the status of this?

tl-cea commented 2 years ago

There is now a big stack of patches related to projid: https://review.gerrithub.io/c/cea-hpc/robinhood/+/541167

To be continued...